[bug] [REST] Dont remove identifier root #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungwy
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Thanks for adding this in @kevinjqliu ! This looks right to me, and I follow your logic in separating out the role of _split_identifier_for_path and _identifier_to_validated_tuple
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* dont remove identifier root * remove catalog in identifier tuple
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* dont remove identifier root * remove catalog in identifier tuple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug while working on the REST catalog.
This PR should be safe since
_identifier_to_tuple_without_catalogwas added in #994, and soon the "catalog name" will be fully deprecated from the table identifier.Also, I made sure that every
_split_identifier_for_pathinrest.pyhas a corresponding_identifier_to_tuple_without_catalogcall.