-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for ns #1169 #1215
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Can you add a few more test scenarios?
- Time64Type with
us
precision - Time64Type with
ns
precision,_downcast_ns_timestamp_to_us
not set - Time64Type with
ns
precision,_downcast_ns_timestamp_to_us
is set
I also want to make sure that downcast works for "Time64Type with ns
precision". So let's add a test on the read/write path to verify this.
@kevinjqliu i have a few questions about the these test case scenarios
|
You can find some information in my previous PR. |
You can use #848 as an example where timestamp downcast was implemented |
@kevinjqliu made the changes suggested in the previous comments and added the test case for the functionality