Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog #1332

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog #1332

merged 2 commits into from
Nov 19, 2024

Conversation

gitzwz
Copy link
Contributor

@gitzwz gitzwz commented Nov 18, 2024 •
edited by Fokko
Loading

Fixes #1331
Fixes #1150

@gitzwz
Copy link
Contributor Author

gitzwz commented Nov 18, 2024 •
edited
Loading

same problem with #1258, I also added some tests for this.

HonahX
HonahX reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @gitzwz Thanks for fixing this and adding tests for both catalogs.

Just have one minor non-blocking request : )

pyiceberg/catalog/hive.py Outdated Show resolved Hide resolved
Fokko
Fokko approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @gitzwz, and thanks for the review @HonahX 🙌

@Fokko Fokko merged commit a66ddc0 into apache:main Nov 19, 2024
7 checks passed
@gitzwz gitzwz deleted the 1331 branch November 20, 2024 03:50
@kevinjqliu kevinjqliu mentioned this pull request Nov 25, 2024
Merged
@kevinjqliu kevinjqliu changed the title Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog (#1331) Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog Nov 25, 2024
@kevinjqliu kevinjqliu added this to the PyIceberg 0.8.1 release milestone Nov 26, 2024
@kevinjqliu kevinjqliu mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonahX HonahX HonahX approved these changes

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PyIceberg 0.8.1 release
4 participants
@gitzwz @Fokko @HonahX @kevinjqliu