Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Order update #476

Merged
merged 11 commits into from
Feb 29, 2024
Merged

Sort Order update #476

merged 11 commits into from
Feb 29, 2024

Conversation

anupam-saini
Copy link
Contributor

@anupam-saini anupam-saini commented Feb 27, 2024

Adds ability to add and update the default sort order via update_table_metadata

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, can you check the tests and CI? make install && make lint

pyiceberg/table/metadata.py Outdated Show resolved Hide resolved
@anupam-saini
Copy link
Contributor Author

anupam-saini commented Feb 27, 2024

Thanks for working on this, can you check the tests and CI? make install && make lint

My bad, missed it this time. Fixed in the latest revision

pyiceberg/table/sorting.py Outdated Show resolved Hide resolved
pyiceberg/table/sorting.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions, but apart from that it looks good 👍

@Fokko Fokko merged commit 0d22add into apache:main Feb 29, 2024
@anupam-saini anupam-saini deleted the as-sort-order branch February 29, 2024 15:20
himadripal pushed a commit to himadripal/iceberg-python that referenced this pull request Mar 1, 2024
* Implement sort order update

* Cleanup

* Add test

* Add test

* Update pyiceberg/table/metadata.py

Co-authored-by: Fokko Driesprong <fokko@apache.org>

* Lint

* Nits

* Nits

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants