Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail on warning when releasing #80

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Don't fail on warning when releasing #80

merged 1 commit into from
Oct 16, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Oct 16, 2023 •
edited
Loading

When we test the binaries, we also fail on errors, which is more strict than in our regular CI

@rdblue
Copy link
Contributor

rdblue commented Oct 16, 2023

Should we make -Werror part of CI?

@Fokko
Copy link
Contributor Author

Fokko commented Oct 16, 2023

@rdblue Yes, this effort is going on at #33. It is tricky because it also catches warnings from external libraries (Ray threw some warnings), but I would love to get this in at some point.

@Fokko Fokko merged commit a8d98a4 into apache:main Oct 16, 2023
6 checks passed
@Fokko Fokko deleted the fd-dont-fail-on-warning branch October 16, 2023 20:44
@Fokko Fokko added this to the PyIceberg 0.5.1 release milestone Oct 16, 2023
Fokko added a commit that referenced this pull request Oct 16, 2023
@Fokko
Don't fail on warning when releasing (#80)
7f5bc51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdblue rdblue rdblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PyIceberg 0.5.1 release
Development

Successfully merging this pull request may close these issues.
2 participants
@Fokko @rdblue