Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history inspect table #828

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Add history inspect table #828

merged 1 commit into from
Jun 26, 2024

Conversation

ndrluis
Copy link
Collaborator

@ndrluis ndrluis commented Jun 18, 2024

Reference: #511

@ndrluis ndrluis force-pushed the metadata-history branch 2 times, most recently from 40ed82d to 60fc121 Compare June 18, 2024 16:58
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! added some minor nits

pyiceberg/table/__init__.py Outdated Show resolved Hide resolved
@ndrluis ndrluis force-pushed the metadata-history branch 2 times, most recently from bf4df63 to b2344de Compare June 21, 2024 22:07
@ndrluis ndrluis requested a review from kevinjqliu June 24, 2024 13:19
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM

@kevinjqliu
Copy link
Contributor

r? @HonahX @Fokko PTAL

@Fokko Fokko mentioned this pull request Jun 25, 2024
8 tasks
@ndrluis ndrluis force-pushed the metadata-history branch from b2344de to 813773a Compare June 26, 2024 21:02
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @ndrluis for working on this, and thanks @kevinjqliu for the review 🙌

@Fokko Fokko merged commit 0e381fa into apache:main Jun 26, 2024
7 checks passed
@Fokko Fokko mentioned this pull request Jun 27, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants