Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: avro schema names for manifest and manifest_list #182

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Fix: avro schema names for manifest and manifest_list #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfbb699
fix avro schema names for manifest and manifest_list
JanKaul Feb 1, 2024
7f565e4
Merge branch 'main' into fix-avro-schema
Fokko Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/iceberg/src/spec/manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ mod _const_schema {
)),
];
let schema = Schema::builder().with_fields(fields).build()?;
schema_to_avro_schema("manifest", &schema)
schema_to_avro_schema("manifest_entry", &schema)
}

pub(super) fn manifest_schema_v1(partition_type: StructType) -> Result<AvroSchema, Error> {
Expand Down Expand Up @@ -696,7 +696,7 @@ mod _const_schema {
)),
];
let schema = Schema::builder().with_fields(fields).build().unwrap();
schema_to_avro_schema("manifest", &schema)
schema_to_avro_schema("manifest_entry", &schema)
}
}

Expand Down
4 changes: 2 additions & 2 deletions crates/iceberg/src/spec/manifest_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,10 +495,10 @@ mod _const_schema {
};

pub(super) static MANIFEST_LIST_AVRO_SCHEMA_V1: Lazy<AvroSchema> =
Lazy::new(|| schema_to_avro_schema("manifest_list", &V1_SCHEMA).unwrap());
Lazy::new(|| schema_to_avro_schema("manifest_file", &V1_SCHEMA).unwrap());

pub(super) static MANIFEST_LIST_AVRO_SCHEMA_V2: Lazy<AvroSchema> =
Lazy::new(|| schema_to_avro_schema("manifest_list", &V2_SCHEMA).unwrap());
Lazy::new(|| schema_to_avro_schema("manifest_file", &V2_SCHEMA).unwrap());
}

/// Entry in a manifest list.
Expand Down
Loading