feat: SQL Catalog - Tables #610
Conversation
Signed-off-by: callum-ryan <19956159+callum-ryan@users.noreply.github.com>
Signed-off-by: callum-ryan <19956159+callum-ryan@users.noreply.github.com>
Signed-off-by: callum-ryan <19956159+callum-ryan@users.noreply.github.com>
Signed-off-by: callum-ryan <19956159+callum-ryan@users.noreply.github.com>
Signed-off-by: callum-ryan <19956159+callum-ryan@users.noreply.github.com>
callum-ryan
force-pushed
the
feat/sql-catalog-tables
branch
from
3de1771
to
8229ea8
Compare
Signed-off-by: callum-ryan <19956159+callum-ryan@users.noreply.github.com>
Signed-off-by: callum-ryan <19956159+callum-ryan@users.noreply.github.com>
There was a problem hiding this comment.
Thanks @callum-ryan for this great pr! Generally LGTM, I've left some minor points to fix, others are great! One thing I want to ask is that do we have plan for tests against other databases such as postgres, mysql?
Signed-off-by: callum-ryan <19956159+callum-ryan@users.noreply.github.com>
Thanks @liurenjie1024, I have fixed the points raised. I'm happy to take a look at integration tests for PostgreSQL and MySQL, it will take me some extra time as I am unfamiliar with the way these tests run for the repo. The REST catalog tests seem to be doing what I'd need to spin up some containers with the appropriate backends. |
this is a WIP. Pulling tests in from @fqaiser94's original recommended test set as I go.