-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Core: Support case-insensitivity for column names in PartitionSpec (#…
- Loading branch information
Showing
6 changed files
with
1,093 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
api/src/test/java/org/apache/iceberg/TestSchemaCaseSensitivity.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.iceberg; | ||
|
||
import static org.apache.iceberg.types.Types.NestedField.required; | ||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; | ||
|
||
import org.apache.iceberg.types.Types; | ||
import org.junit.jupiter.api.Test; | ||
|
||
public class TestSchemaCaseSensitivity { | ||
|
||
@Test | ||
public void testCaseInsensitiveFieldCollision() { | ||
Schema schema = | ||
new Schema( | ||
required(1, "id", Types.LongType.get()), | ||
required(2, "data", Types.StringType.get()), | ||
required(3, "DATA", Types.StringType.get())); | ||
assertThatIllegalArgumentException() | ||
.isThrownBy(() -> schema.caseInsensitiveFindField("DATA")) | ||
.withMessage("Cannot build lower case index: data and DATA collide"); | ||
} | ||
|
||
@Test | ||
public void testCaseSensitiveFindField() { | ||
Schema schema = | ||
new Schema( | ||
required(1, "id", Types.LongType.get()), | ||
required(2, "data", Types.StringType.get()), | ||
required(3, "DATA", Types.StringType.get())); | ||
|
||
Types.NestedField actual1 = schema.findField("data"); | ||
assertThat(actual1).isEqualTo(Types.NestedField.required(2, "data", Types.StringType.get())); | ||
Types.NestedField actual2 = schema.findField("DATA"); | ||
assertThat(actual2).isEqualTo(Types.NestedField.required(3, "DATA", Types.StringType.get())); | ||
} | ||
|
||
@Test | ||
public void testCaseInsensitiveField() { | ||
Schema schema = | ||
new Schema( | ||
required(1, "id", Types.LongType.get()), required(2, "data", Types.StringType.get())); | ||
|
||
Types.NestedField actual1 = schema.caseInsensitiveFindField("DATA"); | ||
assertThat(actual1).isEqualTo(Types.NestedField.required(2, "data", Types.StringType.get())); | ||
} | ||
} |
Oops, something went wrong.