S3OutputStream: Don't complete multipart upload on finalize (#10874)

apache · Aug 20, 2024 · b76d81a · b76d81a
1 parent 2f2c367
commit b76d81a
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java b/aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
@@ -253,6 +253,10 @@ private void newStream() throws IOException {
 
   @Override
   public void close() throws IOException {
+    close(true);
+  }
+
+  private void close(boolean completeUploads) throws IOException {
     if (closed) {
       return;
     }
@@ -262,7 +266,9 @@ public void close() throws IOException {
 
     try {
       stream.close();
-      completeUploads();
+      if (completeUploads) {
+        completeUploads();
+      }
     } finally {
       cleanUpStagingFiles();
     }
@@ -480,7 +486,7 @@ private void createStagingDirectoryIfNotExists() throws IOException, SecurityExc
   protected void finalize() throws Throwable {
     super.finalize();
     if (!closed) {
-      close(); // releasing resources is more important than printing the warning
+      close(false); // releasing resources is more important than printing the warning
       String trace = Joiner.on("\n\t").join(Arrays.copyOfRange(createStack, 1, createStack.length));
       LOG.warn("Unclosed output stream created by:\n\t{}", trace);
     }