Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10275 - fix NullPointerException #10284

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

slessard
Copy link

@slessard slessard commented May 8, 2024

Fix NullPointerException when trying to add the vector's class name to the message for an UnsupportedOperationException.

This PR will handle the case where value is null. This fixes the NullPointerException I reported in issue #10275. Still, I suspect there is a larger issue at play. I suspect there is supposed to be some kind of ArrowVectorAccessor class for accessing null values.

Please see the bug report #10275 for additional context and details

Fix NullPointerException when trying to add the vector's class name to the message for an UnsupportedOperationException
build.gradle Outdated Show resolved Hide resolved
@nastra
Copy link
Contributor

nastra commented May 9, 2024

I think it would be good to add a test that reproduces the issue you described in TestParquetVectorizedReads

@slessard
Copy link
Author

@nastra I believe the bug I am trying to fix is associated with Arrow readers, not Spark readers. The file in which you requested I add a unit test is specific to Spark. Is there a place I can add an arrow vectorized reader test?

sl255051 and others added 2 commits June 11, 2024 15:30
This test more closely follows the reproduction steps described in issue apache#10275
@slessard
Copy link
Author

@nastra I've added a new unit test in iceberg/arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java. I believe / hope this new unit tests satisfies your requirements.

Copy link

github-actions bot commented Nov 2, 2024

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants