-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10275 - fix NullPointerException #10284
base: main
Are you sure you want to change the base?
Conversation
Fix NullPointerException when trying to add the vector's class name to the message for an UnsupportedOperationException
...src/test/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactoryTest.java
Outdated
Show resolved
Hide resolved
I think it would be good to add a test that reproduces the issue you described in |
@nastra I believe the bug I am trying to fix is associated with Arrow readers, not Spark readers. The file in which you requested I add a unit test is specific to Spark. Is there a place I can add an arrow vectorized reader test? |
This test more closely follows the reproduction steps described in issue apache#10275
@nastra I've added a new unit test in iceberg/arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java. I believe / hope this new unit tests satisfies your requirements. |
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
…eaderTest.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
…eaderTest.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Fix NullPointerException when trying to add the vector's class name to the message for an UnsupportedOperationException.
This PR will handle the case where
value
is null. This fixes the NullPointerException I reported in issue #10275. Still, I suspect there is a larger issue at play. I suspect there is supposed to be some kind of ArrowVectorAccessor class for accessing null values.Please see the bug report #10275 for additional context and details