Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when reading struct-type data without an id in iceberg-parquet #11378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joyCurry30
Copy link

Fix issue: #11214
Fix when reading struct-type data without an id in iceberg-parquet, it returns null values.

@joyCurry30
Copy link
Author

@nastra Can you help review this PR? Thanks a lot.

@nastra
Copy link
Contributor

nastra commented Oct 24, 2024

@joyCurry30 I'll take a look early next week but this should at least have a test that reproduces the issue you're trying to fix

@joyCurry30
Copy link
Author

@joyCurry30 I'll take a look early next week but this should at least have a test that reproduces the issue you're trying to fix

Ok, I will add a test for this issue.

Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 25, 2024
@nastra nastra added not-stale and removed stale labels Nov 25, 2024
@nastra
Copy link
Contributor

nastra commented Nov 25, 2024

@joyCurry30 please ping me once you added the test and I'll take a look

@joyCurry30 joyCurry30 force-pushed the Icebert-11214 branch 2 times, most recently from 73776cc to 3bc6636 Compare November 25, 2024 12:08
@joyCurry30
Copy link
Author

@nastra Sorry for replying so late. I've added the related test cases. Please review the code for me. If you have any suggestions, I would be happy to make the changes.

@nastra nastra requested a review from Fokko November 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants