-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Revert Parquet to 1.13.1 #11462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
approved these changes
Nov 4, 2024
Fokko
approved these changes
Nov 4, 2024
Some Flink Tests Broken, Rerunning |
danielcweeks
approved these changes
Nov 4, 2024
Same test failed again,
|
Also fails locally |
@RussellSpitzer Easiest is probably to revert this commit: b8c2b20 |
Thanks @Fokko ! Note that we should probably fix these tests so that they don't hardwire expected values irrelevant fields |
This reverts commit b8c2b20. apache/parquet-java#3040 Was discovered by @pan3793 in Parquet 1.14.(0,1,2,3).
RussellSpitzer
force-pushed
the
RevertParquet
branch
from
November 4, 2024 18:31
6cde9c7
to
296a4b5
Compare
3 tasks
RussellSpitzer
added a commit
to RussellSpitzer/iceberg
that referenced
this pull request
Nov 4, 2024
…ache#11462) This reverts commit b8c2b20. apache/parquet-java#3040 Was discovered by @pan3793 in Parquet 1.14.(0,1,2,3).
Please review the 1.7.0 RC1 CherryPicks
#11466
…On Mon, Nov 4, 2024 at 12:18 PM Fokko Driesprong ***@***.***> wrote:
@RussellSpitzer <https://github.com/RussellSpitzer> Easiest is probably
to revert this commit: b8c2b20
<b8c2b20>
—
Reply to this email directly, view it on GitHub
<#11462 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADE2YNQIAS2UTQ66S65AMLZ66263AVCNFSM6AAAAABREWUJQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVGQYDCMRRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
RussellSpitzer
added a commit
that referenced
this pull request
Nov 4, 2024
This reverts commit b8c2b20. apache/parquet-java#3040 Was discovered by @pan3793 in Parquet 1.14.(0,1,2,3).
Fokko
added a commit
to Fokko/iceberg
that referenced
this pull request
Nov 8, 2024
…)" (apache#11462)" This reverts commit 7cc16fa.
Fokko
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache/parquet-java#3040 -
Was discovered by @pan3793 in Parquet 1.14.(0,1,2,3). This is considered a critical data loss issue so we will pull back parquet to avoid the vulnerability.