Revert "Core: Update TableMetadataParser to ensure all streams closed (#11220)" #11621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apache#11220)" This reverts commit 2b55fef.
bryanck
approved these changes
Nov 21, 2024
amogh-jahagirdar
approved these changes
Nov 21, 2024
|
Thanks @hussein-awala , agree with just reverting this first. |
bryanck
pushed a commit
that referenced
this pull request
Nov 21, 2024
Merged
RussellSpitzer
pushed a commit
that referenced
this pull request
Nov 21, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
…apache#11220)" (apache#11621) This reverts commit 2b55fef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2b55fef.
#11220 introduced a new bug instead of fixing the original issue, where it fixed the case where there is an exception in the GZIPOutputStream constructor, but if there is not, the stream will be closed when try-with-resources tries to close it and it will throw an exception.
The original issue will be fixed by #11609.