ORC: Enable predicate pushdown and remove metrics workaround for Timestamps #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Nov 1, 2020
| // { "orc", "timestamp", "2018-06-29T10:02:34.000000", "2018-06-29T15:02:34.000000" }, | ||
| // { "orc", "timestamptz", "2018-06-29T10:02:34.000000+00:00", "2018-06-29T10:02:34.000000-07:00" }, | ||
| { "orc", "timestamp", "2018-06-29T10:02:34.000000", "2018-06-29T15:02:34.000000" }, | ||
| { "orc", "timestamptz", "2018-06-29T10:02:34.000000+00:00", "2018-06-29T10:02:34.000000-07:00" }, |
There was a problem hiding this comment.
Shouldn't we be using values that have microseconds?
rdblue
approved these changes
Nov 1, 2020
|
The changes look good to me. I would like to have tests that exercise microsecond precision, but the commented out cases already used rounded values so I don't think it is a blocker for this fix. Thanks @shardulm94! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that ORC-611 is fixed, ORC will store statistics for Timestamp types with nanosecond precision. So we can push down predicates and also rely on timestamp statistics reported back by ORC.
For older ORC files which only contain millisecond precision stats, ORC will subtract/add 1 millisecond to the min/max so that the lower/upper bounds are valid and correctly represent the values in the data.