Hive: Avoid closing null writer in output committer abortTask #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have tests for this? (Like Mocked writer which throws an exception on close()) |
pvary
approved these changes
Feb 1, 2021
|
Thanks, @marton-bod! And thanks for reviewing, @pvary! |
aokolnychyi
pushed a commit
that referenced
this pull request
Mar 24, 2021
Co-authored-by: Marton Bod <mbod@cloudera.com>
coolderli
pushed a commit
to coolderli/iceberg
that referenced
this pull request
Apr 26, 2021
…#2150) Co-authored-by: Marton Bod <mbod@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we experience a failure during task commit (
HiveIcebergOutputCommitter#commitTask), we'll have a problem during task abortion (HiveIcebergOutputCommitter#abortTask) because the committer has already removed its writer from theHiveIcebergRecordWriter's static map, thereforeabortTaskwill run into NPE when dereferencing the writer.To solve this, the
commitTaskshould call Map#get instead of Map#remove initially, and only remove the reference from the map once it has successfully completed.