Core: Add check-status config to TableProperties. #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
May 19, 2021
|
This looks good to me, but we should clean up the property name if it hasn't been in a release yet. |
|
@rdblue @aokolnychyi I have checked the latest tag 0.11.1, the |
rdblue
reviewed
May 21, 2021
| @@ -36,9 +36,18 @@ private TableProperties() { | |||
| public static final String COMMIT_TOTAL_RETRY_TIME_MS = "commit.retry.total-timeout-ms"; | |||
| public static final int COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT = 1800000; // 30 minutes | |||
|
|
|||
| public static final String COMMIT_NUM_STATUS_CHECKS = "commit.num-status-checks"; | |||
| public static final String COMMIT_NUM_STATUS_CHECKS = "commit.status-checks.num-retries"; | |||
There was a problem hiding this comment.
The other properties are in commit.status-check, not commit.status-checks. Could you remove the extra s?
There was a problem hiding this comment.
Nevermind, I could do it to the PR through github. I'll merge when tests are passing.
rdblue
approved these changes
May 21, 2021
|
Merged! Can you also update the table properties docs, @coolderli? |
|
@rdblue OK, I will add the document as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the minWaitMs and maxWaitMs are 1000 by default, we should add the configs of check-status to TableProperties.
I don't know if the default values I configured are appropriate.