privacy and terms of service routable links added #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuashuai
reviewed
Dec 4, 2024
| @@ -33,6 +33,13 @@ const Index = () => { | |||
| <footer className="bg-light"> | |||
| <Container className="py-3"> | |||
| <p className="text-center mb-0 small text-secondary"> | |||
| <a className="m-2" href="/privacy" target="_blank"> | |||
| @@ -33,6 +33,13 @@ const Index = () => { | |||
| <footer className="bg-light"> | |||
| <Container className="py-3"> | |||
| <p className="text-center mb-0 small text-secondary"> | |||
| <a className="m-2" href="/privacy" target="_blank"> | |||
| Privacy Policy | |||
| Privacy Policy | ||
| </a> | ||
| <a href="/tos" target="_blank"> | ||
| Terms of Service |
There was a problem hiding this comment.
if u have the transaletd privacy policy and terms of service it will surely work out
There was a problem hiding this comment.
if u have the transaletd privacy policy and terms of service it will surely work out
What I mean is that Terms of Services should use i18n translation, not the content inside.
eg：
// import useTranslation
import { Trans, useTranslation } from 'react-i18next';
// Add translated content in tooter in `i18m/en_US.yaml`
footer:
build_on: >-
Powered by <1> Apache Answer </1>- the open-source software that powers Q&A
communities.<br />Made with love © {{cc}}.
privacy: Privacy Policy
terms_of_service:
// Use where translation is required on the page
const { t } = useTranslation('translation', { keyPrefix: 'footer' });
<a className="me-2" href="/privacy" target="_blank">
{t('privacy')}
</a>
<a href="/tos" target="_blank">
{t('terms_of_service')}
</a>
fenbox
requested changes
Dec 4, 2024
| @@ -33,6 +33,13 @@ const Index = () => { | |||
| <footer className="bg-light"> | |||
| <Container className="py-3"> | |||
| <p className="text-center mb-0 small text-secondary"> | |||
| <a className="m-2" href="/privacy" target="_blank"> | |||
There was a problem hiding this comment.
m-2 has margins in multiple directions and can be changed to me-2
Are you still following this feature? If no adjustments are made this week, I will close the PR so that others can continue to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1187 done!!