Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Disable background IO threads by default #7164

Closed
zhztheplayer opened this issue Sep 9, 2024 · 3 comments
Closed

[VL] Disable background IO threads by default #7164

zhztheplayer opened this issue Sep 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@zhztheplayer
Copy link
Member

zhztheplayer commented Sep 9, 2024

Velox's background IO threads (typically used for split preloading) have been causing some locking issues since it's not aligned with Spark's threading model. For example: #7161.

And it also causes slow runtime filter: facebookincubator/velox#10173.

So we are exploring opportunity to disable it by default until these related issues be resolved. Meanwhile would like to here from users for thoughts.

@zhli1142015
Copy link
Contributor

Hello @zhztheplayer ,
May I ask some details about the issue #7161, did this happend recently or it exists from the time when this flag is enabled by default? As I don't recall there is such issue before.

This feature would impact outr perf number, as remote stroage access takes time, this would help reduce it. Do we have any plan to fix the issues and re-enable it?
Thanks.

@zhztheplayer
Copy link
Member Author

zhztheplayer commented Sep 9, 2024

Hi @zhli1142015 , as mentioned offline, issue #7161 is not a new one and should exist for long time. I assume your scenario is not memory-bound so IO threads could work stably without spilling.

Although PR #7165 for this issue is filed, we can still be tracking on any possible solutions for #7161 after the PR is merged. And I am also adding one TPC benchmark job for iothreads=on in the PR in case loosing test coverage. So I hope we can finally minimize the overall impacts on your use cases.

@zhli1142015
Copy link
Contributor

Thanks, make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants