Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Aggregate window gets the wrong result in 1.2.0 #7194

Closed
ccat3z opened this issue Sep 11, 2024 · 6 comments
Closed

[VL] Aggregate window gets the wrong result in 1.2.0 #7194

ccat3z opened this issue Sep 11, 2024 · 6 comments
Assignees
Labels
bug Something isn't working triage

Comments

@ccat3z
Copy link
Contributor

ccat3z commented Sep 11, 2024

Backend

VL (Velox)

Bug description

Aggregate window gets the wrong result

-- Data
(for { x <- 1 to 4500 } yield { (x,1) }).toDF("id", "order_num")
     
-- Query
SELECT
  id,
  SUM(num) OVER(ORDER BY num DESC) AS sum
FROM test

Expect: sum: 4500

Actual: sum: 4096 ... 4500

Spark version

None

Spark configurations

No response

System information

No response

Relevant logs

No response

@ccat3z ccat3z added bug Something isn't working triage labels Sep 11, 2024
@ccat3z
Copy link
Contributor Author

ccat3z commented Sep 11, 2024

cc @kecookier

@ccat3z
Copy link
Contributor Author

ccat3z commented Sep 11, 2024

This issue can be solved by disabling RowsStreamingWindowBuild. I guess that RowsStreamingWindowBuild might not be compatible with some aggregate case. I tried copying the logic of 'supportRowsStreaming()' from the update branch, but it didn't work. cc @JkSelf

@JkSelf
Copy link
Contributor

JkSelf commented Sep 11, 2024

@ccat3z I will look at this issue later. Thanks.

@JkSelf
Copy link
Contributor

JkSelf commented Sep 12, 2024

@ccat3z Can you help to verify facebookincubator/velox#10979 in your env? Thanks.

@ccat3z
Copy link
Contributor Author

ccat3z commented Sep 12, 2024

@ccat3z Can you help to verify facebookincubator/velox#10979 in your env? Thanks.

It works. Thanks.

@JkSelf
Copy link
Contributor

JkSelf commented Sep 14, 2024

Fixed in facebookincubator/velox#10979.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants