[Gluten-1.2] Backport facebookincubator#9025 and facebookincubator#10979 to fix the result mismatch in RowsStreamingWindowBuild #499
+574
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(9025)" This reverts commit f34c9b1.
…kincubator#9025) Summary: Unlike `StreamingWindowBuild`, `RowLevelStreamingWindowBuild ` in this PR is capable of processing window functions as rows arrive within a single partition, without the need to wait for the entire partition to be ready. This approach can significantly reduce memory usage, especially when a single partition contains a large amount of data. It is particularly suited for optimizing `rank `and `row_number `functions, as well as aggregate window functions with a default frame. The detailed discussions is [here](facebookincubator#8975). The design doc is [here](https://docs.google.com/document/d/17ONSJHK8XP5Lixm8XBl01RMNl4ntpixiVFe693ahw6k/edit?usp=sharing). Pull Request resolved: facebookincubator#9025 Test Plan: Run through 10hrs fuzzer testing Reviewed By: kagamiori Differential Revision: D61473798 Pulled By: xiaoxmeng fbshipit-source-id: 569a752770395330c48a3521bd5421eb89f5623d
…r#10979) Summary: For a Range frame, it is necessary to ensure that the peer is ready before commencing the window function computation Pull Request resolved: facebookincubator#10979 Reviewed By: kagamiori Differential Revision: D62622816 Pulled By: xiaoxmeng fbshipit-source-id: 1a9911da416c867c9e295242a05d0f33fbc2e22d
ccat3z
changed the title
|
@weiting-chen @JkSelf Can you help to review this PR? |
JkSelf
reviewed
Sep 19, 2024
| @@ -132,7 +132,7 @@ TEST_F(WindowTest, rowBasedStreamingWindowOOM) { | |||
|
|
|||
| VELOX_ASSERT_THROW( | |||
| readCursor(params, [](Task*) {}), | |||
| "Exceeded memory pool capacity after attempt to grow capacity through arbitration."); | |||
| "Exceeded memory pool cap of"); | |||
There was a problem hiding this comment.
@ccat3z Why need this change?
There was a problem hiding this comment.
facebookincubator#10506 changed exception message, which not included in branch 1.2
|
The code looks fine to me. |
weiting-chen
approved these changes
Sep 20, 2024
|
After merge the code, I will trigger another test in Gluten for branch-1.2 to see if there is any other issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport facebookincubator#9025 and facebookincubator#10979 to fix apache/incubator-gluten#7194.