Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4813] Replace resize/reserve to resize_extact/reserve_exact to reduce memory #4824

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

taiyang-li
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #4813)

Copy link

github-actions bot commented Mar 1, 2024

#4813

Copy link

github-actions bot commented Mar 1, 2024

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Mar 1, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Mar 4, 2024

Run Gluten Clickhouse CI

@baibaichen
Copy link
Contributor

性能没啥变化,内存确实减少

before image
after image

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 3156fcf into apache:main Mar 4, 2024
7 checks passed
taiyang-li added a commit to bigo-sg/gluten that referenced this pull request Mar 25, 2024
taiyang-li added a commit to bigo-sg/gluten that referenced this pull request Oct 8, 2024
taiyang-li added a commit to bigo-sg/gluten that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] use resize_exact or reserve_exact to reduce memory consumption
2 participants