Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Allow replacing installed minio package #4825

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Mar 1, 2024

What changes were proposed in this pull request?

To fix a failure when building docker image from cache.

How was this patch tested?

Manual test & internal docker build verification.

Copy link

github-actions bot commented Mar 1, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE PHILO-HE changed the title [VL] Allow replace installed minio package [VL] Allow replacing installed minio package Mar 1, 2024
@PHILO-HE PHILO-HE merged commit 612cead into apache:main Mar 1, 2024
17 of 18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4825_time.csv log/native_master_02_29_2024_22d9fe3c8_time.csv difference percentage
q1 33.27 33.44 0.174 100.52%
q2 26.10 27.05 0.952 103.65%
q3 37.82 35.95 -1.871 95.05%
q4 37.23 39.22 1.992 105.35%
q5 70.61 71.30 0.689 100.98%
q6 7.16 7.43 0.264 103.68%
q7 86.12 85.83 -0.283 99.67%
q8 86.66 85.20 -1.456 98.32%
q9 124.53 118.37 -6.152 95.06%
q10 45.65 43.82 -1.835 95.98%
q11 20.48 20.13 -0.349 98.29%
q12 27.30 26.26 -1.041 96.19%
q13 45.33 46.41 1.073 102.37%
q14 20.76 20.53 -0.231 98.89%
q15 29.57 28.82 -0.753 97.45%
q16 14.13 12.90 -1.233 91.28%
q17 103.23 103.50 0.267 100.26%
q18 147.60 149.47 1.865 101.26%
q19 12.79 12.55 -0.239 98.13%
q20 26.61 28.87 2.257 108.48%
q21 224.58 227.08 2.500 101.11%
q22 13.78 13.78 -0.002 99.99%
total 1241.33 1237.92 -3.412 99.73%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants