Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN] Rename CelebornHashBasedColumnarShuffleWriter to CelebornColumnarShuffleWriter #6391

Merged
merged 1 commit into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1 +1 @@
org.apache.spark.shuffle.CHCelebornHashBasedColumnarShuffleWriterFactory
org.apache.spark.shuffle.CHCelebornColumnarShuffleWriterFactory
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ import org.apache.celeborn.common.CelebornConf
import java.io.IOException
import java.util.Locale

class CHCelebornHashBasedColumnarShuffleWriter[K, V](
class CHCelebornColumnarShuffleWriter[K, V](
shuffleId: Int,
handle: CelebornShuffleHandle[K, V, V],
context: TaskContext,
celebornConf: CelebornConf,
client: ShuffleClient,
writeMetrics: ShuffleWriteMetricsReporter)
extends CelebornHashBasedColumnarShuffleWriter[K, V](
extends CelebornColumnarShuffleWriter[K, V](
shuffleId: Int,
handle,
context,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import org.apache.spark.shuffle.gluten.celeborn.CelebornShuffleWriterFactory
import org.apache.celeborn.client.ShuffleClient
import org.apache.celeborn.common.CelebornConf

class CHCelebornHashBasedColumnarShuffleWriterFactory extends CelebornShuffleWriterFactory {
class CHCelebornColumnarShuffleWriterFactory extends CelebornShuffleWriterFactory {
override def backendName(): String = CHBackend.BACKEND_NAME

override def createShuffleWriterInstance[K, V](
Expand All @@ -35,7 +35,7 @@ class CHCelebornHashBasedColumnarShuffleWriterFactory extends CelebornShuffleWri
celebornConf: CelebornConf,
client: ShuffleClient,
writeMetrics: ShuffleWriteMetricsReporter): ShuffleWriter[K, V] = {
new CHCelebornHashBasedColumnarShuffleWriter[K, V](
new CHCelebornColumnarShuffleWriter[K, V](
shuffleId,
handle,
context,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import org.apache.celeborn.common.CelebornConf
import java.io.IOException
import java.util.Locale

abstract class CelebornHashBasedColumnarShuffleWriter[K, V](
abstract class CelebornColumnarShuffleWriter[K, V](
shuffleId: Int,
handle: CelebornShuffleHandle[K, V, V],
context: TaskContext,
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
org.apache.spark.shuffle.VeloxCelebornHashBasedColumnarShuffleWriterFactory
org.apache.spark.shuffle.VeloxCelebornColumnarShuffleWriterFactory
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ import org.apache.celeborn.common.CelebornConf

import java.io.IOException

class VeloxCelebornHashBasedColumnarShuffleWriter[K, V](
class VeloxCelebornColumnarShuffleWriter[K, V](
shuffleId: Int,
handle: CelebornShuffleHandle[K, V, V],
context: TaskContext,
celebornConf: CelebornConf,
client: ShuffleClient,
writeMetrics: ShuffleWriteMetricsReporter)
extends CelebornHashBasedColumnarShuffleWriter[K, V](
extends CelebornColumnarShuffleWriter[K, V](
shuffleId,
handle,
context,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import org.apache.spark.shuffle.gluten.celeborn.CelebornShuffleWriterFactory
import org.apache.celeborn.client.ShuffleClient
import org.apache.celeborn.common.CelebornConf

class VeloxCelebornHashBasedColumnarShuffleWriterFactory extends CelebornShuffleWriterFactory {
class VeloxCelebornColumnarShuffleWriterFactory extends CelebornShuffleWriterFactory {
override def backendName(): String = VeloxBackend.BACKEND_NAME

override def createShuffleWriterInstance[K, V](
Expand All @@ -35,7 +35,7 @@ class VeloxCelebornHashBasedColumnarShuffleWriterFactory extends CelebornShuffle
celebornConf: CelebornConf,
client: ShuffleClient,
writeMetrics: ShuffleWriteMetricsReporter): ShuffleWriter[K, V] = {
new VeloxCelebornHashBasedColumnarShuffleWriter[K, V](
new VeloxCelebornColumnarShuffleWriter[K, V](
shuffleId,
handle,
context,
Expand Down
Loading