[VL] Improve package scripts #6569
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
@weiting-chen Do we still need the package.sh if we switch to static build? I never used the .sh. |
@FelixYBW Does |
Yes. |
Got it, thanks. I also prefer this packaging way. This PR also adds build thirdparty for |
dev/package-vcpkg.sh
Outdated
| ./dev/buildbundle-veloxbe.sh --build_tests=ON --build_benchmarks=ON --enable_s3=ON --enable_hdfs=ON "$@" | ||
|
|
||
| # make thirdparty package | ||
| ./dev/build-thirdparty.sh |
There was a problem hiding this comment.
This script is for vcpkg build with all dependencies statically linked. No need to pack shared libs.
There was a problem hiding this comment.
This script is for vcpkg build with all dependencies statically linked. No need to pack shared libs.
Sorry, I didn't look at the document carefully, does it mean we no longer need the thirdparty lib jar when using package-vcpkg.sh? I will try it, thank you.
There was a problem hiding this comment.
@wForget, yes, third-party jar is useless when vcpkg build is enabled.
There was a problem hiding this comment.
Thank you, I will close this PR.
There was a problem hiding this comment.
Extract build-thirdparty.sh script
Set PROMPT_ALWAYS_RESPOND=y for package scripts
Pass package arguments to buildbundle-veloxbe.sh
Are these improvements reasonable? If so, I will continue working
There was a problem hiding this comment.
@wForget , yes, you can just keep these changes. Thanks!
|
@wForget, the weekly build job failed, seems related to this pr. Could you help take a look? |
Sorry, this PR unexpectedly introduced the following code. I will delete it. |
* [MINOR] Remove duplicate mvn packages (#6560) * [VL] Improve package scripts (#6569) * [GLUTEN-6569][VL] Delete unnecessary gcc9 enabling from package script (#6730) * [GLUTEN-7118][VL] Fix duckdb target issue when vcpkg is enabled (#7117) --------- Co-authored-by: Zhen Wang <643348094@qq.com> Co-authored-by: PHILO-HE <feilong.he@intel.com>
What changes were proposed in this pull request?
Improve package scripts:
build-thirdparty.shscriptPROMPT_ALWAYS_RESPOND=yfor package scriptsbuildbundle-veloxbe.shpackage-vcpkg.shHow was this patch tested?
Manual package test