[Improvement][C++] Use inherit to implement EdgesCollection #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acezen
force-pushed
the
237-edgescollection
branch
from
23092d9
to
a46d539
Compare
|
I think the best way to adapt this change is getting EdgesCollection from factory function directly. For details, you need:
If there are new problems, please reach out to me. |
acezen
force-pushed
the
237-edgescollection
branch
from
fa27eb4
to
a448cc8
Compare
acezen
force-pushed
the
237-edgescollection
branch
from
ae525f7
to
d07702c
Compare
lixueclaire
reviewed
Oct 10, 2023
cpp/examples/bfs_father_example.cc
Outdated
| @@ -36,8 +36,8 @@ int main(int argc, char* argv[]) { | |||
| auto maybe_vertices = | |||
| GAR_NAMESPACE::ConstructVerticesCollection(graph_info, label); | |||
| ASSERT(maybe_vertices.status().ok()); | |||
| auto& vertices = maybe_vertices.value(); | |||
| int num_vertices = vertices.size(); | |||
| auto vertices = maybe_vertices.value(); | |||
There was a problem hiding this comment.
Maybe use auto& consistently is better?
acezen
force-pushed
the
237-edgescollection
branch
from
ee6e01e
to
587804b
Compare
|
@lixueclaire any comments? |
Thespica
requested changes
Oct 11, 2023
| @@ -19,10 +20,12 @@ include_directories("src/main/native") | |||
| include_directories("src/test/native") | |||
|
|
|||
| find_package(Arrow REQUIRED) | |||
| find_package(gar REQUIRED) | |||
| include(graphar-cpp) | |||
| build_graphar_cpp() | |||
There was a problem hiding this comment.
Developers usually need recompile JNI code through CMake, but not need rebuild GraphAr C++ library.
Maybe check C++ library is installed before build it? Or make it optional?
There was a problem hiding this comment.
BTW, we also need to check installed C++ library's version if we choose the first solution.
There was a problem hiding this comment.
The C++ library is actually just build for the first time, so i think it's ok for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
variantof EdgesCollection with inheritance to implement polymorphism of different adj list type edges collection.Types of changes
What types of changes does your code introduce to GraphAr?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments