-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat][Spark] Add examples to show how to load/dump data from/to GraphAr for Nebula #244
Conversation
Dear Great Creators of GraphAr Project!
This will enable the contributor to be part of the Hactoberfest project and it means a lot! Thanks and appreciate your help! Best Regards, Wey |
Dear Wey, Thank you for reaching out to us and expressing your excitement about enabling the GraphAr - NebulaGraph connection in Hacktoberfest. We appreciate your interest in our project and we are happy to support you. Best regards, |
The Thanks for the EXCITING work to enabling the feature we expect. As @lixueclaire said, we are delighted to review the PR and collaborate with the Hactoberfest project. |
Thanks for your help, but I confirmed that the label should be CC: @wey-gu |
Dear Xue, Wow, thanks so very much for the prompt help, care and powerful support! |
Dear @acezen Wow, many thanks for the super-fast and warm support!!! |
OMG, I'm so very sorry/ashamed to provide a typo on the label... let's wait @acezen for another go 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please rebase to main.
Thanks for the job.
hi, @liuxiaocs7, I not sure the PR can close the issue vesoft-inc/nebula-spark-connector#76 because it's just an example to exchange a specific data(basketballplayergraph graph) between nebula and GraphAr, the example can't use for other data. BTW, @wey-gu @lixueclaire, do you have some suggestions for that? |
Sure, thank you for your suggestion, I will remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~ Thanks for your contribution. It would be even better if you could update the documentation or create an issue about it.
Sounds good! Maybe you can refer to #243 for this. |
@liuxiaocs7 the example data apache/incubator-graphar-testing#4 has been merge, you can update the testing submodule to latest commit. |
Nebula2GraphAr
and GraphAr2Nebula
to show how to exchange data between Nebula and GraphAr
Nebula2GraphAr
and GraphAr2Nebula
to show how to exchange data between Nebula and GraphAr
Issue created here: #248, i'll finish ASAP. |
Hi, @acezen, should i follow this to update |
Amazing OpenSource collaboration! I would like to express my utmost respect, appreciation, and admiration! |
@liuxiaocs7 think of submodule a way to let the parent module track submoudle as a folder only on its git hash. With that in mind, when upating a submodle, we could just do the needed pull(to ensure its hash is the one from the remote) and do git add as a commit on the parent module. What git submodule update was just to pull submodule based on its tracked git hash. |
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
close #34
example in gar-test: apache/incubator-graphar-testing#4
Types of changes
What types of changes does your code introduce to GraphAr?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...