Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Spark] Complement the error messages of spark SDK #278

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Nov 8, 2023

Proposed changes

Complement the error messages of spark, throw exception with error message.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close #140

@acezen acezen changed the title [Improvement][Spark] Complement the error messages of spark [Improvement][Spark] Complement the error messages of spark SDK Nov 8, 2023
@acezen acezen merged commit bde169c into apache:main Nov 8, 2023
3 checks passed
@acezen acezen deleted the 140-spark-error-message branch November 8, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]Complements the error message and handling of C++ and Spark
1 participant