Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][C++] Fixes compilation warnings in C++ SDK #388

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

sighingnow
Copy link
Contributor

Proposed changes

Fixes several compilation warnings in C++ SDK.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow requested a review from acezen March 4, 2024 11:13
@acezen acezen changed the title Fixes compilation warnings in C++ SDK [Improvement][C++] Fixes compilation warnings in C++ SDK Mar 4, 2024
Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@acezen acezen merged commit 4bf186a into apache:main Mar 4, 2024
4 checks passed
@sighingnow sighingnow deleted the ht/fixes-warnings branch March 4, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants