Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT][C++] Not allow setting custom namespace for code clarity #415

Merged
merged 2 commits into from
Mar 27, 2024
Merged

[FEAT][C++] Not allow setting custom namespace for code clarity #415

merged 2 commits into from
Mar 27, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Mar 26, 2024 •
edited
Loading

Proposed changes

As issue #414 describe

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close #414

@acezen
[FEAT][C++] Remove the custom namespace setting feature
d4fbcea 
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen acezen force-pushed the 414-not-allow-custom-namespace-anymore branch from 9c573ca to d4fbcea Compare March 26, 2024 06:04
lixueclaire
lixueclaire reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the examples in documentations to use graphar instead of GAR_NAMESPACE?

@acezen
Update the document
94111c8 
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen
Copy link
Contributor Author

acezen commented Mar 27, 2024

Could you please update the examples in documentations to use graphar instead of GAR_NAMESPACE?

Done.

lixueclaire
lixueclaire approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 6e77ed7 into apache:main Mar 27, 2024
4 checks passed
@acezen acezen deleted the 414-not-allow-custom-namespace-anymore branch March 27, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lixueclaire lixueclaire lixueclaire approved these changes

@Thespica Thespica Awaiting requested review from Thespica

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat][C++] Remove the custom namespace setting feature
2 participants
@acezen @lixueclaire