[BugFix][C++] Cast to correct schema when get chunk with property reader #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
acezen
changed the title
acezen
force-pushed
the
219-fix-inconsistent-type-csv
branch
from
5b06f26
to
162509a
Compare
Elssky
pushed a commit
to Elssky/incubator-graphar
that referenced
this pull request
Oct 8, 2024
…der (apache#456) ## Proposed changes as issue apache#219 describe, the chunk table get from arrow chunk reader may not has the same type with schema. This change help to fix the problem by cast the chunk table to what they should be(schema), if cast failed, raise error. ## Further comments fixes apache#219 --------- Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
as issue #219 describe, the chunk table get from arrow chunk reader may not has the same type with schema.
This change help to fix the problem by cast the chunk table to what they should be(schema), if cast failed, raise error.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
fixes #219