Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java-info] Add vertex, edge, graph info #484

Merged
merged 1 commit into from
May 20, 2024

Conversation

Thespica
Copy link
Contributor

Reason for this PR

The third step in issue #478 .

What changes are included in this PR?

  • Add vertex, edge, graph info;
  • Move AdjList, Property, PropertyGroup into info package.

Are these changes tested?

no

Are there any user-facing changes?

no

Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, John, you may need to add some API document in the code , that would help user/developer to know what the method use for

@SemyonSinchenko
Copy link
Member

Hi, John, you may need to add some API document in the code , that would help user/developer to know what the method use for

Is it the right time for that? Because we are in the middle of a decision about using proto: with proto info, classes should be refactored again. I would like to recommend postponing writing docs.

@acezen
Copy link
Contributor

acezen commented May 18, 2024

Hi, John, you may need to add some API document in the code , that would help user/developer to know what the method use for

Is it the right time for that? Because we are in the middle of a decision about using proto: with proto info, classes should be refactored again. I would like to recommend postponing writing docs.

Yes, you are right, considering the proto decision, postponing the docs avoids refactor again, thanks Sem

@acezen acezen merged commit 0026d4e into apache:main May 20, 2024
1 check passed
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants