Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(license): add reference code to java related third-party code #485

Merged

Conversation

acezen
Copy link
Contributor

@acezen acezen commented May 20, 2024

Reason for this PR

as apache legal discussion describe, if the code is modified on top of the reference code, we can also add the corresponding AL2 header.

What changes are included in this PR?

add the corresponding AL2 header to reference code if modified on top of it.

Are these changes tested?

no need to test

Are there any user-facing changes?

no

…if the code has been modified on top of reference code

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen acezen changed the title fix(license): merging ASF license header and Alibaba Group copyright if the code has been modified on top of reference code fix(license): May 20, 2024
@acezen acezen changed the title fix(license): fix(license): add reference code to java related third-party code May 20, 2024
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 0136d16 into apache:main May 20, 2024
2 checks passed
@acezen acezen deleted the license-for-modify-code-on-top-of-third-party branch May 20, 2024 08:57
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
…ache#485)

* fix(license): merging ASF licence header and Alibaba Group copyright if the code has been modified on top of reference code

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* Update

* Update NOTICE

---------

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants