Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(c++): Update the Catch2 dependency to v3 and remove the Catch2 submodule #511

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Jun 1, 2024

Reason for this PR

as #509 describe

What changes are included in this PR?

  • remove the Catch2 submodule
  • update Catch2 to v3
  • update the related CI

Are these changes tested?

yes

Are there any user-facing changes?

no

Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 82a02f1 into apache:main Jun 4, 2024
5 checks passed
@acezen acezen deleted the bumpup-catch2-to-v3 branch June 4, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(c++): Update the Catch2 dependency to v3 and remove the Catch2 submodule
2 participants