Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Update Kubernetes proxy URLs #3405

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Conversation

ShawnZhong
Copy link
Contributor

Fix #3404

Follow the Kubernetes proxy URLs documented here (Note that proxy is placed after the service name instead of /api/v1):

http://kubernetes_master_address/api/v1/namespaces/namespace_name/services/service_name[:port_name]/proxy

@ShawnZhong
Copy link
Contributor Author

Note that the helm configuration file at https://storage.googleapis.com/heron-charts needs to be updated as well. Otherwise, users following the helm guide will not be able to get any stats from heron UI.

image

I believe the file has already been updated in this repository (see below), but the file at https://storage.googleapis.com/heron-charts was not changed for a while (The last modified time is 2018-04-18).

command: ["sh", "-c"]
args:
- >-
heron-ui
--port=8889
--base_url={{ .Values.heron.url }}
- name: heron-apiserver

Copy link
Member

@joshfischer1108 joshfischer1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I thought we updated these URLs a while ago. Thanks for catching and fixing this @ShawnZhong

@joshfischer1108
Copy link
Member

I'm going to let this sit for a day and see if anyone else has any feedback.

@nwangtw
Copy link
Contributor

nwangtw commented Nov 28, 2019

I am not familiar with this part but the change looks reasonable. Thanks.

Please feel free to merge.

@joshfischer1108 joshfischer1108 merged commit 06b5acc into apache:master Nov 28, 2019
sreev pushed a commit to sreev/incubator-heron that referenced this pull request Apr 9, 2020
nicknezis pushed a commit that referenced this pull request Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Kubernetes proxy URLs
3 participants