Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Use click instead of argparse in tracker #3599

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

Code0x58
Copy link
Contributor

@Code0x58 Code0x58 commented Aug 4, 2020

This continues on the theme of cleaning out the passing around of a dictionary from argparse for CLIs in heron. This uses click so that CLI help automatically reflects the code, and the types of parameters, and where they come from, are apparent.

@Code0x58 Code0x58 force-pushed the click-tracker branch 5 times, most recently from fce2b57 to 23345dd Compare August 5, 2020 22:59
@Code0x58 Code0x58 marked this pull request as ready for review August 10, 2020 00:40
@joshfischer1108
Copy link
Member

@Code0x58 is this ready to be reviewed?

@Code0x58
Copy link
Contributor Author

Yep. I just updated the PR body to help with context

@nicknezis nicknezis merged commit 98ada0f into apache:master Oct 30, 2020
@Code0x58 Code0x58 deleted the click-tracker branch October 30, 2020 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants