fix: Assert.assertThrows() should check result of exceptionConsumer #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10 ☔ View full report in Codecov by Sentry. |
|
+ @zhenyuT |
|
Seems there's no need to use CompletableFuture in assertThrows method? |
imbajin
reviewed
Nov 27, 2023
hugegraph-common/src/main/java/org/apache/hugegraph/testutil/Assert.java
Show resolved
Hide resolved
hugegraph-common/src/main/java/org/apache/hugegraph/util/ExceptionUtil.java
Outdated
Show resolved
Hide resolved
simon824
previously approved these changes
Nov 30, 2023
javeme
force-pushed
the
assert-throws-bugfix
branch
from
cc5e32a to
68b359e
Compare
imbajin
approved these changes
Nov 30, 2023
simon824
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.