Refactor computer: abstract computer-api from computer-core #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
force-pushed
the
refactor_computer
branch
6 times, most recently
from
28e451b to
e0ac55b
Compare
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
============================================
- Coverage 86.07% 85.82% -0.25%
+ Complexity 3240 3239 -1
============================================
Files 345 344 -1
Lines 12292 12106 -186
Branches 1097 1097
============================================
- Hits 10580 10390 -190
- Misses 1182 1187 +5
+ Partials 530 529 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
coderzc
force-pushed
the
refactor_computer
branch
from
e0ac55b to
83f0956
Compare
coderzc
force-pushed
the
refactor_computer
branch
from
83f0956 to
c63de1f
Compare
coderzc
force-pushed
the
refactor_computer
branch
from
c63de1f to
6836e3f
Compare
javeme
reviewed
Nov 23, 2022
computer-k8s/src/main/java/com/baidu/hugegraph/computer/k8s/driver/KubernetesDriver.java
Outdated
Show resolved
Hide resolved
|
The code looks more reasonable than before |
coderzc
force-pushed
the
refactor_computer
branch
from
8ad2246 to
cfbb9d8
Compare
coderzc
force-pushed
the
refactor_computer
branch
from
cfbb9d8 to
479e45f
Compare
javeme
approved these changes
Nov 24, 2022
coderzc
added a commit
that referenced
this pull request
Nov 24, 2022
* address comment * improve pom and options
imbajin
added a commit
that referenced
this pull request
Nov 25, 2022
* improve package * Refactor computer: abstract computer-api from computer-core (#196) * address comment * improve pom and options * fix package * improve build image * improve start-computer.sh * improve log file * improve start-computer.sh * improve build image * trigger maven cache invalidation * Update ci.yml Co-authored-by: imbajin <jin@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computer-apifromcomputer-core.com/baidu/hugegraph/computer/driver/config/ComputerOptionscomputer-algorithmandcomputer-driveronly depend oncomputer-api.