Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove okhttp1 due to conflicts risk #294

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix: remove okhttp1 due to conflicts risk #294

merged 2 commits into from
Dec 13, 2023

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Dec 12, 2023 •
edited
Loading

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@simon824 simon824 merged commit 8580a2e into master Dec 13, 2023
7 checks passed
@simon824 simon824 deleted the exclude-okhttp1 branch December 13, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon824 simon824 simon824 approved these changes

@JackyYangPassion JackyYangPassion JackyYangPassion approved these changes

@javeme javeme Awaiting requested review from javeme

@coderzc coderzc Awaiting requested review from coderzc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imbajin @JackyYangPassion @simon824