-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce HugeGraphSparkLoader #282
Conversation
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
============================================
- Coverage 75.74% 71.12% -4.62%
+ Complexity 1847 877 -970
============================================
Files 235 82 -153
Lines 7766 3816 -3950
Branches 685 456 -229
============================================
- Hits 5882 2714 -3168
+ Misses 1501 898 -603
+ Partials 383 204 -179
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, it's a very nice enhancement. Some tiny comments
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
could enable check-style plugin to check code |
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/spark/HugeGraphSparkLoader.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closed #281
basic version of HugeGraphSparkLoader
test cmd
The options are divided into two parts,
spark options
andhugegraph-loader options
. (no sorting required)