feat: add hubble dockerfile #295
Conversation
|
TODO: build the source directly Link issue |
| @@ -70,10 +70,10 @@ | |||
| echo -e "Hubble-FE build successfully.\n" | |||
|
|
|||
| cd ${top.level.dir} && pwd | |||
| rm -rf ${final.name}/ui | |||
| cp -r ${hubble-fe.dir}/build ${final.name}/ui | |||
| rm -rf ${release.name}/ui | |||
There was a problem hiding this comment.
Remove the directory version information here, so that version does not need to be added to the dockerfile, which is more general
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
=========================================
Coverage 72.90% 72.90%
Complexity 1849 1849
=========================================
Files 242 242
Lines 8084 8084
Branches 716 716
=========================================
Hits 5894 5894
Misses 1807 1807
Partials 383 383 Continue to review full report at Codecov.
|
hugegraph-hubble/Dockerfile
Outdated
| ENV HUBBLE_HOME /opt/hugegraph-hubble | ||
| WORKDIR ${HUBBLE_HOME} | ||
|
|
||
| ADD ./hugegraph-hubble/hugegraph-hubble $HUBBLE_HOME |
There was a problem hiding this comment.
where is this relative path? (seems we miss the install step?)
| <arguments> | ||
| <argument>build</argument> | ||
| <argument>--no-cache</argument> | ||
| <argument>-t</argument> | ||
| <argument>${docker.hub}/${parent.artifactId}:${docker.tag}</argument> | ||
| <argument>-t</argument> | ||
| <argument>${docker.hub}/${parent.artifactId}:latest</argument> | ||
| <argument>${project.basedir}</argument> | ||
| <argument>--file=../Dockerfile</argument> | ||
| </arguments> |
There was a problem hiding this comment.
how could we link to dockerhub & test it? if someone want to build the image in local machine
run docker built -t . is enough?
There was a problem hiding this comment.
If having permission, we can execute mvn deploy anywhere to push the image to any repository by modify the parameters.
This configuration is just for building the image, the below configuration is for building and pushing。
No description provided.