Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hubble): ui component protocol information #372

Merged
merged 3 commits into from
Nov 18, 2022
Merged

chore(hubble): ui component protocol information #372

merged 3 commits into from
Nov 18, 2022

Conversation

wanganjuan
Copy link
Contributor

ui component protocol information

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #372 (bbefcda) into master (14ea43e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #372   +/-   ##
=========================================
  Coverage     57.52%   57.52%           
  Complexity     1864     1864           
=========================================
  Files           263      263           
  Lines         10272    10272           
  Branches        877      877           
=========================================
  Hits           5909     5909           
  Misses         3979     3979           
  Partials        384      384           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin
Copy link
Member

imbajin commented Nov 18, 2022

Seems fine

@simon824 could check it again

simon824
simon824 previously approved these changes Nov 18, 2022
Copy link
Member

@simon824 simon824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imbajin
imbajin previously approved these changes Nov 18, 2022
@wanganjuan wanganjuan dismissed stale reviews from imbajin and simon824 via bbefcda November 18, 2022 12:30
@wanganjuan
Copy link
Contributor Author

image

Some configuration files have keywords that need to be processed

@imbajin imbajin changed the title ui component protocol information chore(hubble): ui component protocol information Nov 18, 2022
@imbajin imbajin merged commit aa4b168 into apache:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants