rename binary #387
Merged
rename binary #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
=========================================
Coverage 62.55% 62.55%
Complexity 1866 1866
=========================================
Files 260 260
Lines 9405 9405
Branches 872 872
=========================================
Hits 5883 5883
Misses 3140 3140
Partials 382 382 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
approved these changes
Dec 3, 2022
imbajin
reviewed
Dec 3, 2022
| <final.name>${release.name}-${project.version}</final.name> | ||
| <final.name>apache-${release.name}-incubating-${project.version}</final.name> |
There was a problem hiding this comment.
@z7658329 should use one param for these modules?
seems we just define it in root-pom is OK?
imbajin
reviewed
Dec 3, 2022
| @@ -61,7 +61,7 @@ | |||
| <properties> | |||
| <revision>1.0.0</revision> | |||
| <release.name>${project.artifactId}</release.name> | |||
| <final.name>${release.name}-${project.version}</final.name> | |||
| <final.name>apache-${release.name}-incubating-${project.version}</final.name> | |||
There was a problem hiding this comment.
the child module will extend it automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.