Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: keep hadoop-hdfs-client and hadoop-common version consistent #457

Merged
merged 3 commits into from
May 10, 2023
Merged

chore: keep hadoop-hdfs-client and hadoop-common version consistent #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfa1927
keep hadoop-hdfs-client and hadoop-common version consistent
May 10, 2023
f72ab22
keep hadoop-hdfs-client and hadoop-common version consistent
May 10, 2023
30ee20e
update the dependency in known-dependencies.txt
May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hugegraph-dist/scripts/dependency/known-dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ hadoop-client-3.1.1.jar
hadoop-common-3.1.1.jar
hadoop-common-3.3.1.jar
hadoop-hdfs-3.1.1.jar
hadoop-hdfs-client-2.10.1.jar
hadoop-hdfs-client-3.3.1.jar
hadoop-hdfs-client-3.1.1.jar
hadoop-mapreduce-client-common-3.1.1.jar
hadoop-mapreduce-client-core-3.1.1.jar
Expand Down
5 changes: 3 additions & 2 deletions hugegraph-loader/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<release.name>${project.artifactId}</release.name>
<final.name>apache-${release.name}-incubating-${project.version}</final.name>
<jackson.version>2.12.3</jackson.version>
<hadoop.version>3.3.1</hadoop.version>
Copy link
Member

@imbajin imbajin May 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could check whether there are other similar Hadoop dependencies in the project at the same time. If there are multiple module used it, you can put the version attribute under the root to unify them (pom)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do it later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do it later.

@chenlixuan We can do it in the next pr, unify the dependencies versions of the entire project.

<assembly.dir>${project.basedir}/assembly</assembly.dir>
<assembly.descriptor.dir>${assembly.dir}/descriptor</assembly.descriptor.dir>
<assembly.static.dir>${assembly.dir}/static</assembly.static.dir>
Expand Down Expand Up @@ -307,7 +308,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
<version>3.3.1</version>
<version>${hadoop.version}</version>
<exclusions>
<exclusion>
<groupId>org.slf4j</groupId>
Expand Down Expand Up @@ -350,7 +351,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-hdfs-client</artifactId>
<version>2.10.1</version>
<version>${hadoop.version}</version>
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
Expand Down