Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checkstyle && add suppressions.xml #500

Merged
merged 7 commits into from
Sep 4, 2023
Merged

fix: checkstyle && add suppressions.xml #500

merged 7 commits into from
Sep 4, 2023

Conversation

liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Aug 1, 2023 •
edited
Loading

continute this pr: #385

after excludes some questions, it works fine:

PS D:\Development\Code\HugeGraph\incubator-hugegraph-toolchain> mvn checkstyle:check
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:                                                    
[INFO]                                                                         
[INFO] hugegraph-toolchain                                                [pom]
[INFO] hugegraph-client                                                   [jar]
[INFO] hugegraph-loader                                                   [jar]
[INFO] hugegraph-tools                                                    [jar]
[INFO] hugegraph-hubble                                                   [pom]
[INFO] hubble-be                                                          [jar]
[INFO] hubble-dist                                                        [jar]
[INFO] hugegraph-dist                                                     [jar]
[INFO]                                                                         
[INFO] --------------< org.apache.hugegraph:hugegraph-toolchain >--------------
[INFO] Building hugegraph-toolchain 1.0.0                                 [1/8]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ hugegraph-toolchain ---
[INFO] ?始检查???
?查完成??
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ---------------< org.apache.hugegraph:hugegraph-client >----------------
[INFO] Building hugegraph-client 1.0.0                                    [2/8]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ hugegraph-client ---
[INFO] ?始检查???
?查完成??
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ---------------< org.apache.hugegraph:hugegraph-loader >----------------
[INFO] Building hugegraph-loader 1.0.0                                    [3/8]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ hugegraph-loader ---
[INFO] ?始检查???
?查完成??
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ----------------< org.apache.hugegraph:hugegraph-tools >----------------
[INFO] Building hugegraph-tools 1.0.0                                     [4/8]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ hugegraph-tools ---
[INFO] ?始检查???
?查完成??
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ---------------< org.apache.hugegraph:hugegraph-hubble >----------------
[INFO] Building hugegraph-hubble 1.0.0                                    [5/8]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ hugegraph-hubble ---
[INFO] ?始检查???
?查完成??
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] -------------------< org.apache.hugegraph:hubble-be >-------------------
[INFO] Building hubble-be 1.0.0                                           [6/8]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ hubble-be ---
[INFO] ?始检查???
?查完成??
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ------------------< org.apache.hugegraph:hubble-dist >------------------
[INFO] Building hubble-dist 1.0.0                                         [7/8]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ hubble-dist ---
[INFO] ?始检查???
?查完成??
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ----------------< org.apache.hugegraph:hugegraph-dist >-----------------
[INFO] Building hugegraph-dist 1.0.0                                      [8/8]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ hugegraph-dist ---
[INFO] ?始检查???
?查完成??
[INFO] You have 0 Checkstyle violations.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for hugegraph-toolchain 1.0.0:
[INFO]
[INFO] hugegraph-toolchain ................................ SUCCESS [  0.910 s]
[INFO] hugegraph-client ................................... SUCCESS [  0.080 s]
[INFO] hugegraph-loader ................................... SUCCESS [  0.081 s]
[INFO] hugegraph-tools .................................... SUCCESS [  0.047 s]
[INFO] hugegraph-hubble ................................... SUCCESS [  0.046 s]
[INFO] hubble-be .......................................... SUCCESS [  0.065 s]
[INFO] hubble-dist ........................................ SUCCESS [  0.039 s]
[INFO] hugegraph-dist ..................................... SUCCESS [  0.038 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.607 s
[INFO] Finished at: 2023-08-01T17:21:50+08:00
[INFO] ------------------------------------------------------------------------

@github-actions github-actions bot added hubble hugegraph-hubble loader hugegraph-loader client hugegraph-client tools hugegraph-tools labels Aug 1, 2023
@liuxiaocs7 liuxiaocs7 changed the title fix: checkstyle && add supressions fix: checkstyle && add suppressions.xml Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #500 (bd70fe3) into master (549ca82) will decrease coverage by 0.01%.
The diff coverage is 19.35%.

@@             Coverage Diff              @@
##             master     #500      +/-   ##
============================================
- Coverage     62.48%   62.48%   -0.01%     
  Complexity     1868     1868              
============================================
  Files           260      260              
  Lines          9432     9434       +2     
  Branches        875      875              
============================================
+ Hits           5894     5895       +1     
- Misses         3154     3155       +1     
  Partials        384      384
Files Changed Coverage Δ
.../hugegraph/api/traverser/JaccardSimilarityAPI.java 100.00% <ø> (ø)
...hugegraph/exception/InvalidOperationException.java 50.00% <ø> (ø)
...e/hugegraph/serializer/direct/HBaseSerializer.java 0.00% <0.00%> (ø)
...e/hugegraph/serializer/direct/reuse/BytesDemo.java 0.00% <0.00%> (ø)
.../hugegraph/serializer/direct/util/IdGenerator.java 0.00% <ø> (ø)
...ph/serializer/direct/util/SplicingIdGenerator.java 0.00% <ø> (ø)
.../hugegraph/loader/flink/HugeGraphOutputFormat.java 0.00% <0.00%> (ø)
.../hugegraph/loader/reader/file/LocalFileReader.java 81.81% <ø> (ø)
...e/hugegraph/loader/spark/HugeGraphSparkLoader.java 0.00% <0.00%> (ø)
...rg/apache/hugegraph/exception/ServerException.java 68.18% <50.00%> (-0.87%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

imbajin
imbajin reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also try to clean code? (with IDEA inner plugins)

tools/suppressions.xml Outdated Show resolved Hide resolved
@liuxiaocs7 @imbajin
Update tools/suppressions.xml
bd70fe3 
Co-authored-by: imbajin <jin@apache.org>
@github-actions
Copy link

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

imbajin
imbajin approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge it first, address other style later

@imbajin imbajin merged commit 18ae76b into apache:master Sep 4, 2023
@liuxiaocs7 liuxiaocs7 mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

@z7658329 z7658329 z7658329 approved these changes

Assignees
No one assigned
Labels
client hugegraph-client hubble hugegraph-hubble inactive loader hugegraph-loader tools hugegraph-tools
Projects
HugeGraph Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuxiaocs7 @z7658329 @imbajin