-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hubble): build with node and yarn #543
Conversation
<groupId>com.github.eirslett</groupId> | ||
<artifactId>frontend-maven-plugin</artifactId> | ||
<version>1.14.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need update the LICENSE/NOTICE & 3rd party file maybe?
https://hugegraph.apache.org/docs/contribution-guidelines/contribute/#321-check-licenses
Note: Local test success with |
e84dcd9
to
3f2554a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #543 +/- ##
============================================
- Coverage 62.49% 62.46% -0.04%
+ Complexity 1903 1902 -1
============================================
Files 262 262
Lines 9541 9533 -8
Branches 886 886
============================================
- Hits 5963 5955 -8
Misses 3190 3190
Partials 388 388 ☔ View full report in Codecov by Sentry. |
refer to https://stackoverflow.com/questions/60667548/frontend-maven-plugin-fails-to-execute-goal |
Note, add CC: @imbajin and @returnToInnocence |
Purpose of the PR
Introduce https://github.com/eirslett/frontend-maven-plugin to install node and yarn automatically when build.
After PR: #542 merged and env prepared, this pr could continue.
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need