refactor(hubble): enhance maven front plugin #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
|
cc @imbajin and @aroundabout maybe need to test when build image |
imbajin
reviewed
Jan 8, 2024
| <yarnVersion>${build.yarn.version}</yarnVersion> | ||
| <nodeDownloadRoot>https://npm.taobao.org/mirrors/node/</nodeDownloadRoot> | ||
| <npmDownloadRoot>https://registry.npmmirror.com/npm/-/</npmDownloadRoot> | ||
| <yarnDownloadRoot>https://repo.huaweicloud.com/yarn/</yarnDownloadRoot> |
There was a problem hiding this comment.
could we use the same mirror url from taobao?
There was a problem hiding this comment.
seems not now, The download address is automatically spliced based on url and version
prefix/{version}/yarn-{version}.tar.gz
Optional download address：
https://repo.huaweicloud.com/yarn/v1.22.21/yarn-v1.22.21.tar.gz √
https://registry.npmmirror.com/yarn/-/yarn-1.22.21.tgz ×
but we can not download file from this url below.
https://registry.npmmirror.com/yarn/v1.22.21/yarn-v1.22.21.tar.gz
liuxiaocs7
changed the title
imbajin
approved these changes
Feb 20, 2024
| <nodeVersion>${build.node.version}</nodeVersion> | ||
| <yarnVersion>${build.yarn.version}</yarnVersion> | ||
| <nodeDownloadRoot>https://mirrors.aliyun.com/nodejs-release/</nodeDownloadRoot> | ||
| <yarnDownloadRoot>https://repo.huaweicloud.com/yarn/</yarnDownloadRoot> |
There was a problem hiding this comment.
TODO: Skip it now & replace it(the mirror address) in future
javeme
approved these changes
Feb 24, 2024
1 task
|
related issue #584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
follow: #558
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need