Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hubble): yarn install timeout in arm64 #583

Merged
merged 1 commit into from
Mar 3, 2024
Merged

fix(hubble): yarn install timeout in arm64 #583

merged 1 commit into from
Mar 3, 2024

Conversation

liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Feb 28, 2024 •
edited
Loading

Purpose of the PR

image

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working hubble hugegraph-hubble labels Feb 28, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 3, 2024
imbajin
imbajin approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark: long timeout may influence the user experience when network is broken ()

@imbajin imbajin merged commit d70e83f into apache:master Mar 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

@javeme javeme javeme approved these changes

Assignees
No one assigned
Labels
bug Something isn't working hubble hugegraph-hubble lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuxiaocs7 @javeme @imbajin