Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hubble): warp the exception info in HugeClientUtil #589

Merged
merged 15 commits into from
Mar 20, 2024

Conversation

returnToInnocence
Copy link
Contributor

…partial exceptions of hubble and server connection creation

Purpose of the PR

Main Changes

  • constrain the message and cause returned by partial exceptions of hubble and server connection creation, By making the following changes
    • creat new class ExternalGenericException
    • add ExceptionHandler(ExternalGenericException & ConnectException)
    • Encapsulate the final e

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • All kinds of anomalies of /api/v1.2/graph-connections interface are tested

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)
    • add new ExceptionHandler

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

…artial exceptions of hubble and server connection creation
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request hubble hugegraph-hubble hubble-be java Pull requests that update Java code labels Mar 11, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.41%. Comparing base (b066b80) to head (692ba93).
Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #589      +/-   ##
============================================
- Coverage     62.49%   62.41%   -0.08%     
- Complexity     1903     1931      +28     
============================================
  Files           262      267       +5     
  Lines          9541     9739     +198     
  Branches        886      891       +5     
============================================
+ Hits           5963     6079     +116     
- Misses         3190     3267      +77     
- Partials        388      393       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin
imbajin previously approved these changes Mar 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2024
@imbajin imbajin changed the title feat(hugegraph-hubble): constrain the message and cause in HugeClientUtil feat(hubble): warp the exception info in HugeClientUtil Mar 19, 2024
@JackyYangPassion JackyYangPassion dismissed stale reviews from imbajin and themself via 692ba93 March 19, 2024 15:34
@JackyYangPassion JackyYangPassion merged commit 7bfcd66 into apache:master Mar 20, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client hugegraph-client enhancement New feature or request hubble hugegraph-hubble hubble-be java Pull requests that update Java code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Constraint hubble and server create a partial exception to the connection process
3 participants