-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] FlatMapperIterator should be closed after usage #2280
Comments
There are indeed some iterators in the current code that have not been finally closed. U can confirm their lifecycle, if they are indeed legacy and may cause potential impact, you can help submit PR fixes (there should be some places in the class) |
I have scanned the code, this is only case and u can review the above PR. |
close [Bug] FlatMapperIterator should be closed after usage #2280
close [Bug] FlatMapperIterator should be closed after usage apache#2280
close [Bug] FlatMapperIterator should be closed after usage apache#2280
close [Bug] FlatMapperIterator should be closed after usage #2280
Bug Type (问题类型)
others (please edit later)
Before submit
Environment (环境信息)
Connections, streams, files, and other classes that implement the Closeable interface or its super-interface, AutoCloseable, needs to be closed after use. Further, that close call must be made in a finally block otherwise an exception could keep the call from being made. Preferably, when class implements AutoCloseable, resource should be created using "try-with-resources" pattern and will be closed automatically.
Failure to properly close resources will result in a resource leak which could bring first the application and then perhaps the box the application is on to their knees.
Expected & Actual behavior (期望与实际表现)
close FlatMapperIterator after usage
Vertex/Edge example (问题点 / 边数据举例)
No response
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
No response
The text was updated successfully, but these errors were encountered: